The status/result of a deployment should correctly reflect the result of the external approval process

We are making use of the external approval process to check at deployment time if the deployment is allowed to happen.

Our process consists of two steps:

- Step 1: Make an external call with the 'Send HTTP Call' step

- Step 2: A groovy script to print the output & set the Status to "Success" or "Failure" through a Post-Processing script

When a deployment is triggered, we always set the "post-deploy-put-url" in our 'requestApplicationProcess' request that points to a web hook in Jenkins & 'post-deploy-message' is set to '${p:finalStatus}'. Based on the response of the webhook call, we either proceed with the Jenkins pipeline. If we get a status that is failed, the pipeline gets aborted.

The problem that we are facing is two-fold:

1) UCD doesn't trigger our callback when the External Approval Process fails

2) When the deployment failed, and it clearly says 'External approval failed. This

process request has been aborted.' in the Execution Log, when we ask the status of the request with the api 'https://xxxx/cli/applicationProcessRequest/requestStatus?request=181e7dbf-2a9d-991d-ccff-40b29e1a3550'

Then the response is:

{

"status": "PENDING",

"result": "SCHEDULED FOR FUTURE"

}

The above statuses are clearly incorrect. When an external approval process fails, the deployment will never continue. Not now, not in the future, so the fact that UCD still sees & reports them as 'PENDING' - 'SCHEDULED FOR FUTURE' is clearly wrong.